Fix port::Thread to use std::jthread over std::thread#14608
Open
johnmcfarlane wants to merge 1 commit intofacebook:mainfrom
Open
Fix port::Thread to use std::jthread over std::thread#14608johnmcfarlane wants to merge 1 commit intofacebook:mainfrom
johnmcfarlane wants to merge 1 commit intofacebook:mainfrom
Conversation
to avoid surprising std::terminate in a failure path reported in facebook#13303.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While discussing #14603 as a solution to #13303, it occurred to me that the real issue is the loss of data when the program is terminated without first existing threads. The solution provided by C++20 is
std::jthread. This MR floats simply replacing some use ofstd::threadwithstd::jthreadin the project as an alternative fix to #14603.